perf(@ngtools/webpack): reduce redundant module rebuilds when cache is restored#22377
Merged
dgp1130 merged 1 commit intoangular:masterfrom Dec 15, 2021
alan-agius4:perf-fs-cache-rebuild-ngtools
Merged
perf(@ngtools/webpack): reduce redundant module rebuilds when cache is restored#22377dgp1130 merged 1 commit intoangular:masterfrom alan-agius4:perf-fs-cache-rebuild-ngtools
dgp1130 merged 1 commit intoangular:masterfrom
alan-agius4:perf-fs-cache-rebuild-ngtools
Conversation
… restored With this change we reduce the redundant module rebuilds when Webpack's FS cache is restored. Previously, when the cache was restored we caused all modules to be rebuild even though their contents didn't change. This is because the file emit history wasn't persisted to disk. This also caused the side effect that Webpack will create additional cache `pack` files due to the unnecessary module rebuilds, which ultimatly causes increase of the size of the cache on disk.
alan-agius4
added
the
target: patch
Collaborator
Author
|
From initial benchmarks it also shows a ~600ms reduction for warm build times on |
dgp1130
approved these changes
Dec 15, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change we reduce the redundant module rebuilds when Webpack's FS cache is restored.
Previously, when the cache was restored we caused all modules to be rebuild even though their contents didn't change. This is because the file emit history wasn't persisted to disk.
This also caused the side effect that Webpack will create additional cache
packfiles due to the unnecessary module rebuilds, which ultimately causes increase of the size of the cache on disk.Partially addresses #22323 (comment)